Add more examples for pyiceberg view#3414
Open
MonkeyCanCode wants to merge 8 commits into
Open
Conversation
gabeiglio
reviewed
May 26, 2026
Contributor
gabeiglio
left a comment
gabeiglio
left a comment
There was a problem hiding this comment.
Thanks for the PR! left some small comments but overall looks good
Author
|
@gabeiglio thanks for the review. All feedbacks had been addressed now. |
ebyhr
reviewed
May 26, 2026
ebyhr
reviewed
May 27, 2026
abnobdoss
approved these changes
May 29, 2026
Author
|
@ebyhr @gabeiglio @abnobdoss @rambleraptor thanks for the reviews and all feedbacks had been addressed. Please take another look. |
rambleraptor
approved these changes
Jun 1, 2026
Contributor
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
Great! Thanks so much for all of the rounds of iteration on this. Docs are such an important place, especially for new users.
ebyhr
reviewed
Jun 1, 2026
Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
ebyhr
approved these changes
Jun 4, 2026
| "docs", | ||
| **{ | ||
| "uri": "http://127.0.0.1:8181", | ||
| "py-io-impl": "pyiceberg.io.pyarrow.PyArrowFileIO", |
Member
There was a problem hiding this comment.
py-io-impl
This is actually an optional parameter for views, right?
Author
There was a problem hiding this comment.
Yes. But the top page also use this, do we not want to be consistent with the doc?
Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3413
Rationale for this change
Adds more examples around view support.
Are these changes tested?
Yes. Those had been tested locally with local Polaris.
Are there any user-facing changes?
No.